The following document contains the results of FindBugs
FindBugs Version is 3.0.0
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
powered.by.sergey.binarystorage.BinaryStorageBOInBlobStoreGAEImpl.getFileInfo(HttpServletRequest) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 131 | Medium |
powered.by.sergey.binarystorage.BinaryStorageBOInBlobStoreGAEImpl.saveFile(InputStream, HttpServletRequest) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 55 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to out in powered.by.sergey.binarystorage.BinaryStorageBOInFileImpl.writeToFile(InputStream, String) | STYLE | DLS_DEAD_LOCAL_STORE | 73 | Medium |
powered.by.sergey.binarystorage.BinaryStorageBOInFileImpl.writeToFile(InputStream, String) may fail to clean up java.io.OutputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 73 | Medium |
powered.by.sergey.binarystorage.BinaryStorageBOInFileImpl.file2Bytes(File) may fail to clean up java.io.InputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 59 | Medium |
powered.by.sergey.binarystorage.BinaryStorageBOInFileImpl.writeToFile(InputStream, String) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 73 | Medium |
Exceptional return value of java.io.File.delete() ignored in powered.by.sergey.binarystorage.BinaryStorageBOInFileImpl.deleteFile(String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 94 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
powered.by.sergey.binarystorage.FileMetadata.getCreatedAt() may expose internal representation by returning FileMetadata.createdAt | MALICIOUS_CODE | EI_EXPOSE_REP | 208 | Medium |
powered.by.sergey.binarystorage.FileMetadata.getLastModifiedAt() may expose internal representation by returning FileMetadata.lastModifiedAt | MALICIOUS_CODE | EI_EXPOSE_REP | 216 | Medium |
powered.by.sergey.binarystorage.FileMetadata.setCreatedAt(Date) may expose internal representation by storing an externally mutable object into FileMetadata.createdAt | MALICIOUS_CODE | EI_EXPOSE_REP2 | 212 | Medium |
powered.by.sergey.binarystorage.FileMetadata.setLastModifiedAt(Date) may expose internal representation by storing an externally mutable object into FileMetadata.lastModifiedAt | MALICIOUS_CODE | EI_EXPOSE_REP2 | 220 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
powered.by.sergey.binarystorage.FileMetadataSet.getCreatedAt() may expose internal representation by returning FileMetadataSet.createdAt | MALICIOUS_CODE | EI_EXPOSE_REP | 65 | Medium |
powered.by.sergey.binarystorage.FileMetadataSet.getLastModifiedAt() may expose internal representation by returning FileMetadataSet.lastModifiedAt | MALICIOUS_CODE | EI_EXPOSE_REP | 73 | Medium |
powered.by.sergey.binarystorage.FileMetadataSet.setCreatedAt(Date) may expose internal representation by storing an externally mutable object into FileMetadataSet.createdAt | MALICIOUS_CODE | EI_EXPOSE_REP2 | 69 | Medium |
powered.by.sergey.binarystorage.FileMetadataSet.setLastModifiedAt(Date) may expose internal representation by storing an externally mutable object into FileMetadataSet.lastModifiedAt | MALICIOUS_CODE | EI_EXPOSE_REP2 | 77 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
powered.by.sergey.binarystorage.FileStorage.getFile() may expose internal representation by returning FileStorage.file | MALICIOUS_CODE | EI_EXPOSE_REP | 59 | Medium |
powered.by.sergey.binarystorage.FileStorage.getTimeStamp() may expose internal representation by returning FileStorage.timeStamp | MALICIOUS_CODE | EI_EXPOSE_REP | 67 | Medium |
powered.by.sergey.binarystorage.FileStorage.setFile(byte[]) may expose internal representation by storing an externally mutable object into FileStorage.file | MALICIOUS_CODE | EI_EXPOSE_REP2 | 63 | Medium |
powered.by.sergey.binarystorage.FileStorage.setTimeStamp(Date) may expose internal representation by storing an externally mutable object into FileStorage.timeStamp | MALICIOUS_CODE | EI_EXPOSE_REP2 | 71 | Medium |